Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix childprocess killing when the parent process SIGINTs #6011

Merged
merged 8 commits into from
Jun 15, 2020

Commits on Jun 12, 2020

  1. Fix childprocess killing when the parent process SIGINTs

    If you `ctrl + c` the Puppeteer parent process, we would sometimes
    not properly handle killing of the child processes. This would then
    leave child processes behind, with running Chromium instances. This
    in turn could block Puppeteer from launching again and results in
    cryptic errors.
    
    Instead of using the generic `process.kill` with the process id
    (which for some reason is negative the pid, which I don't get),
    we can kill the child process directly by calling `proc.kill`.
    TimvdLippe committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    5c801ed View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Configuration menu
    Copy the full SHA
    ca97ff4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e138b20 View commit details
    Browse the repository at this point in the history
  3. Fix SIGINT handler

    TimvdLippe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    518ea4f View commit details
    Browse the repository at this point in the history
  4. Relax check for Windows

    On Windows, it might not always cleanup the process, as it was
    already cleaned up. We can relax the check here.
    TimvdLippe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    c002d48 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7dc3af6 View commit details
    Browse the repository at this point in the history
  6. Fix nits

    TimvdLippe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    7ce43d9 View commit details
    Browse the repository at this point in the history
  7. Fix formatter

    TimvdLippe committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    c62f534 View commit details
    Browse the repository at this point in the history