Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add Page.isJavaScriptEnabled + mark properties as private #5993

Merged
merged 1 commit into from Jun 10, 2020
Merged

feat(api): add Page.isJavaScriptEnabled + mark properties as private #5993

merged 1 commit into from Jun 10, 2020

Commits on Jun 10, 2020

  1. chore: make Page's internals private. 

    Just one was used externally and I wrapped that up in a method. I think
it's a useful method to provide (I can imagine wanting to know if JS is
enabled on a page) so I think there's no harm here (I'd rather that then
have JSHandle reach into a private variable).
    @jackfranklin
    jackfranklin committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    cba5866 View commit details
    Browse the repository at this point in the history