Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate away from Node's EventEmitter #5979

Merged
merged 12 commits into from Jun 15, 2020
Merged

chore: migrate away from Node's EventEmitter #5979

merged 12 commits into from Jun 15, 2020

Commits on Jun 15, 2020

  1. bring back initial mitt

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    ee805fc View commit details
    Browse the repository at this point in the history

  2. reimplementing mitt with tests

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    f2c5485 View commit details
    Browse the repository at this point in the history

  3. Cover our event emitter in tests

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    d66f027 View commit details
    Browse the repository at this point in the history

  4. add spec for on + off and request handling

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    80776ce View commit details
    Browse the repository at this point in the history

  5. Fix the docs for the new event emitter

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    3d777ef View commit details
    Browse the repository at this point in the history

  6. Remove mentions and links of Node's EventEmitter 

    And link to our event emitter instead. This ensures that we don't send
anyone erroneously to the NodeJS docs.
    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    6547d9c View commit details
    Browse the repository at this point in the history

  7. document the new event listener

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    06d8d2c View commit details
    Browse the repository at this point in the history

  8. link to event emitter

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4b0c33c View commit details
    Browse the repository at this point in the history

  9. skip firefox test

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    a991a3d View commit details
    Browse the repository at this point in the history

  10. try enabling ff test

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    1a35776 View commit details
    Browse the repository at this point in the history

  11. ff definitely needs the skip

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    11cf4a9 View commit details
    Browse the repository at this point in the history

  12. Do not document this interface

    @jackfranklin
    jackfranklin committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    069f0d0 View commit details
    Browse the repository at this point in the history