chore: drop Node6 support #4654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node6 was end-of-life'ed in the end of April, 2019, with AWS Lambda prohibiting updaets to the node6 runtime since June 30, 2019. This makes it quite safe for us to remove the Node 6 support from the repository. From now on, all the subsequent commits will require Node 8.9.0+.
|
I think this should be a major change |
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
| "repository": "github:GoogleChrome/puppeteer", | |||
| "engines": { | |||
| "node": ">=6.4.0" | |||
| "node": ">=8.9.0" | |||
There was a problem hiding this comment.
As a practical concern, is there anything from 7 that would break us?
There was a problem hiding this comment.
Not sure. I picked 8 here since it's an LTS release with a clear lifetime.
There was a problem hiding this comment.
Ok. Turns out this only produces a warning.
| * @param {string} text | ||
| * @return {string} | ||
| */ | ||
| function transformAsyncFunctions(text) { |
|
The test: Puppeteer-Web should work over web socket |
| @@ -57,7 +57,8 @@ See [puppeteer vs puppeteer-core](https://github.com/GoogleChrome/puppeteer/blob | |||
|
|
|||
| ### Usage | |||
|
|
|||
| Note: Puppeteer requires at least Node v6.4.0, but the examples below use async/await which is only supported in Node v7.6.0 or greater. | |||
| Note: Prior to v1.18.1, Puppeteer required at least Node v6.4.0. All subsequent versions rely on | |||
| Node 8.9.0+. All examples below use async/await which is only supported in Node v7.6.0 or greater. | |||
There was a problem hiding this comment.
Let's codify the supported Node.js versions over time as well. We could say something like:
Puppeteer follows the latest [maintenance LTS](https://github.com/nodejs/Release#release-schedule) version of Node.
|
Moved to #5045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node6 was end-of-life'ed in the end of April, 2019, with AWS Lambda
prohibiting updaets to the node6 runtime since June 30, 2019.
This makes it quite safe for us to remove the Node 6 support from the
repository.
From now on, all subsequent releases will require Node 8.9.0+.