Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(firefox): properly cleanup networkmanager #4024

Merged
merged 1 commit into from Feb 16, 2019
Merged

fix(firefox): properly cleanup networkmanager #4024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions experimental/puppeteer-firefox/lib/NetworkManager.js
View file
Open in desktop
Expand Up @@ -18,6 +18,10 @@ class NetworkManager extends EventEmitter {
];
}

dispose() {
helper.removeEventListeners(this._eventListeners);
}

setFrameManager(frameManager) {
this._frameManager = frameManager;
}
Expand Down Expand Up @@ -57,10 +61,6 @@ class NetworkManager extends EventEmitter {
this._requests.delete(request._id);
this.emit(Events.NetworkManager.RequestFinished, request);
}

dispose() {
helper.removeEventListeners(this._eventListeners);
}
}

/**
Expand Down
1 change: 1 addition & 0 deletions experimental/puppeteer-firefox/lib/Page.js
View file
Open in desktop
Expand Up @@ -570,6 +570,7 @@ class Page extends EventEmitter {
_onClosed() {
this._isClosed = true;
this._frameManager.dispose();
this._networkManager.dispose();
helper.removeEventListeners(this._eventListeners);
this.emit(Events.Page.Close);
}
Expand Down
2 changes: 1 addition & 1 deletion test/navigation.spec.js
View file
Open in desktop
Expand Up @@ -256,7 +256,7 @@ module.exports.addTests = function({testRunner, expect, Errors, CHROME}) {
process.removeListener('warning', warningHandler);
expect(warning).toBe(null);
});
it_fails_ffox('should not leak listeners during bad navigation', async({page, server}) => {
it('should not leak listeners during bad navigation', async({page, server}) => {
let warning = null;
const warningHandler = w => warning = w;
process.on('warning', warningHandler);
Expand Down