chore: further unify Puppeteer-Firefox tests with Puppeteer #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - unifies assets between tests - enables a few puppeteer tests on Puppeteer-Firefox References puppeteer#3889
JoelEinbinder
approved these changes
Feb 6, 2019
| expect(await page.evaluate(() => window)).toBe(undefined); | ||
| expect(await page.evaluate(() => [Symbol('foo4')])).toBe(undefined); |
There was a problem hiding this comment.
Why didn’t this one work?
There was a problem hiding this comment.
This is split into two tests: the Symbol one is now on line 68
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Drive-by: beautify failing output of
expect.toEqualmatcher.References #3889