Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firefox): mark all Puppeteer tests that are failing on FF #3924

Merged
merged 1 commit into from Feb 6, 2019

Commits on Feb 6, 2019

  1. chore(firefox): mark all Puppeteer tests that are failing on FF

    This patch:
    - introduces new testRunner methods `addTestDSL` and `addSuiteDSL`
      to add annotated test / suite.
    - introduces new test/suite declaration methods: `it_fails_ffox` and
      `describe_fails_ffox`. These are equal to `it`/`describe` for chromium
      tests and to `xit`/`xdescribe` for firefox.
    - marks all unsupported tests with `it_fails_ffox`
    - adds a new command-line flag `'--firefox-status'` to `//test/test.js`.
      This flag dumps current amount of tests that are intentionally skipped
      for Firefox.
    
    End goal: get rid of all `it_fails_ffox` and `describe_fails_ffox`
    tests.
    
    Drive-By: remove cookie tests  "afterEach" hook that was removing
    cookies - it's not needed any more since every test is run in a
    designated browser context.
    
    References puppeteer#3889
    aslushnikov committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    6991a94 View commit details
    Browse the repository at this point in the history