Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle negative area results in computeQuadArea #3413

Merged
merged 5 commits into from
Oct 25, 2018
Merged

fix: handle negative area results in computeQuadArea #3413

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9524c3e
fix(computeQuadArea): handle negative area results in computeQuadArea
zeevrosental Oct 15, 2018
8a4d9c3
fix: handle negative area results in computeQuadArea
zeevrosental Oct 15, 2018
ddc1f31
test(compute_quad_area):
zeevrosental Oct 16, 2018
4ea1faf
Merge branch 'fix-computeQuadArea' of https://github.com/zeevrosental…
zeevrosental Oct 16, 2018
d3599f3
Update ExecutionContext.js
aslushnikov Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ExecutionContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,8 @@ function computeQuadArea(quad) {
const p2 = quad[(i + 1) % quad.length];
area += (p1.x * p2.y - p2.x * p1.y) / 2;
}
if (area < 0)
area = Math.abs(area);
return area;
}

Expand Down
21 changes: 21 additions & 0 deletions test/assets/input/rotatedButton.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html>
<head>
<title>Rotated button test</title>
</head>
<body>
<script src="mouse-helper.js"></script>
<button onclick="clicked();">Click target</button>
<style>
button {
transform: rotateY(180deg);
}
</style>
<script>
window.result = 'Was not clicked';
function clicked() {
result = 'Clicked';
}
</script>
</body>
</html>
5 changes: 5 additions & 0 deletions test/input.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ module.exports.addTests = function({testRunner, expect}) {
await page.click('button');
expect(await page.evaluate(() => window.result)).toBe('Clicked');
});
it('should click a rotated button', async({page, server}) => {
await page.goto(server.PREFIX + '/input/rotatedButton.html');
await page.click('button');
expect(await page.evaluate(() => result)).toBe('Clicked');
});
it('should select the text with mouse', async({page, server}) => {
await page.goto(server.PREFIX + '/input/textarea.html');
await page.focus('textarea');
Expand Down