test: puppeteer.connect with using disconnects the browser
#12371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
using-with-connected-browser-disconnects
branch
from
72de301
to
44bf8f1
Compare
OrKoN
approved these changes
Apr 30, 2024
Lightning00Blade
changed the title
using disconnects the browserusing disconnects the browser
Lightning00Blade
force-pushed
the
using-with-connected-browser-disconnects
branch
from
44bf8f1
to
7e35ba9
Compare
OrKoN
force-pushed
the
using-with-connected-browser-disconnects
branch
from
7e35ba9
to
817828b
Compare
OrKoN
reviewed
May 6, 2024
| @@ -829,6 +829,8 @@ describe('Launcher specs', function () { | |||
| browserWSEndpoint, | |||
| protocol: browser.protocol, | |||
| }); | |||
| remoteClose = remoteBrowser.close.bind(remoteBrowser); | |||
| console.log(remoteClose); | |||
There was a problem hiding this comment.
forgotten console.log @Lightning00Blade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one caveat:
When we spawn a browser and we
disconnectit immediately, its connection is closed so we can't send further commands or close the process.When that happens we need to use
browser.closefrom the second connection to properly close the browser process.