Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate CDP for Firefox #12349

Merged
merged 1 commit into from May 2, 2024
Merged

fix: deprecate CDP for Firefox #12349

merged 1 commit into from May 2, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 26, 2024

This PR adds a deprecation warning if Chrome DevTools Protocol (CDP) is used for Firefox. Instead CDP, use WebDriver BiDi:

import puppeteer from 'puppeteer';

const browser = await puppeteer.launch({
  product: 'firefox',
  protocol: 'webDriverBiDi',
});
const page = await browser.newPage();
...
await browser.close();

Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + maybe we need a call to action if there encounter issues?

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 26, 2024

@Lightning00Blade code to action?

@Lightning00Blade
Copy link
Collaborator

Lightning00Blade commented Apr 26, 2024

@Lightning00Blade code to action?

Typo I wanted to say call to action as there is no issue way for a person to say this is not working file and issue or something else

@OrKoN OrKoN force-pushed the orkon/deprecate-cdp-firefox branch from f5e87e5 to b1272bd Compare April 29, 2024 10:59
@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 29, 2024

@whimboo PTAL I think on our end we are ready to mark CDP support for Firefox as deprecated

@whimboo
Copy link
Collaborator

whimboo commented Apr 29, 2024

@whimboo PTAL I think on our end we are ready to mark CDP support for Firefox as deprecated

I thought that we wanted to do that after the announcement that Puppeteer fully supports Firefox via WebDriver BiDi. For me it feels a bit too early.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 29, 2024

@whimboo we are only 13 tests away from feature-parity with CDP and 147 new tests are passing so I think it is fine to nudge users to try WebDriver BiDi and switch over.

Copy link
Collaborator

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with the team we are fine with this addition. Also because you are not forcing Webdriver BiDi at this point as default which is fine.

@OrKoN OrKoN force-pushed the orkon/deprecate-cdp-firefox branch from 972997d to c5e8015 Compare May 2, 2024 08:21
@OrKoN OrKoN enabled auto-merge (squash) May 2, 2024 08:21
@OrKoN OrKoN merged commit dffad28 into main May 2, 2024
37 checks passed
@OrKoN OrKoN deleted the orkon/deprecate-cdp-firefox branch May 2, 2024 08:28
@release-please release-please bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants