chore: implement improved waitForNavigation
#11929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/update-wait-for-navigation
branch
from
9f305e6
to
dd7f2d5
Compare
|
@OrKoN This PR is expected to fail btw. That's because the navigationStarted event is incorrect. I'm working on a fix in Chromium BiDi. |
jrandolf
force-pushed
the
jrandolf/update-wait-for-navigation
branch
from
dd7f2d5
to
c37cb8f
Compare
OrKoN
force-pushed
the
jrandolf/update-wait-for-navigation
branch
from
c37cb8f
to
c658b83
Compare
|
@jrandolf thanks, after a quick review, it looks good. I will give it another review once it is ready to be landed. |
jrandolf
force-pushed
the
jrandolf/update-wait-for-navigation
branch
from
c658b83
to
fe4cc01
Compare
OrKoN
force-pushed
the
jrandolf/update-wait-for-navigation
branch
from
fe4cc01
to
a468c73
Compare
|
@jrandolf how complicates is a fix or a work-around for chromium-bidi? it looks like the current implementation has additional flakiness as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1882454 (responseCompleted coming after load) |
OrKoN
force-pushed
the
main
branch
4 times, most recently
from
2ff1e4f
to
e0932e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
waitForNavigationthat doesn't validate the expected flow and instead only cares about results.This also modifies the
bidi/coreAPI to match the BiDi spec as defined.