Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the flag disabling bfcache #11047

Merged
merged 1 commit into from Sep 28, 2023
Merged

fix: remove the flag disabling bfcache #11047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/puppeteer-core/src/node/ChromeLauncher.ts
View file
Open in desktop
Expand Up @@ -177,7 +177,6 @@ export class ChromeLauncher extends ProductLauncher {

if (!USE_TAB_TARGET) {
disabledFeatures.push('Prerender2');
disabledFeatures.push('BackForwardCache');
}

const chromeArguments = [
Expand Down
18 changes: 6 additions & 12 deletions test/TestExpectations.json
View file
Open in desktop
Expand Up @@ -1019,6 +1019,12 @@
"parameters": ["webDriverBiDi"],
"expectations": ["PASS"]
},
{
"testIdPattern": "[page.spec] Page Page.select should not throw when select causes navigation",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"],
"expectations": ["PASS"]
},
{
"testIdPattern": "[page.spec] Page Page.select should respect event bubbling",
"platforms": ["darwin", "linux", "win32"],
Expand Down Expand Up @@ -3173,12 +3179,6 @@
"parameters": ["cdp", "firefox"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[page.spec] Page Page.select should not throw when select causes navigation",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["webDriverBiDi"],
"expectations": ["PASS"]
},
{
"testIdPattern": "[page.spec] Page Page.select should work when re-defining top-level Event class",
"platforms": ["darwin", "linux", "win32"],
Expand Down Expand Up @@ -3862,11 +3862,5 @@
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "chrome", "headless"],
"expectations": ["FAIL", "PASS"]
},
{
"testIdPattern": "[coverage.spec] Coverage specs JSCoverage resetOnNavigation should report scripts across navigations when disabled",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "chrome", "new-headless", "tabTarget"],
"expectations": ["FAIL"]
}
]
2 changes: 2 additions & 0 deletions test/src/coverage.spec.ts
View file
Open in desktop
Expand Up @@ -165,6 +165,8 @@ describe('Coverage specs', function () {

await page.coverage.startJSCoverage({resetOnNavigation: false});
await page.goto(server.PREFIX + '/jscoverage/multiple.html');
// TODO: navigating too fast might loose JS coverage data in the browser.
await page.waitForNetworkIdle();
await page.goto(server.EMPTY_PAGE);
const coverage = await page.coverage.stopJSCoverage();
expect(coverage).toHaveLength(2);
Expand Down