Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove boundary conditions for visibility #9249

Merged
merged 1 commit into from Nov 14, 2022
Merged

fix: remove boundary conditions for visibility #9249

merged 1 commit into from Nov 14, 2022

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented Nov 11, 2022

Fixed: #9232

@jrandolf jrandolf merged commit e003513 into main Nov 14, 2022
@jrandolf jrandolf deleted the fix-viewport branch November 14, 2022 08:34
OrKoN pushed a commit that referenced this pull request Nov 23, 2022
🤖 I have created a release *beep* *boop*
---


<details><summary>ng-schematics: 0.1.0</summary>

## 0.1.0 (2022-11-23)


### Features

* **ng-schematics:** Release @puppeteer/ng-schematics
([#9244](#9244))
([be33929](be33929))
</details>

<details><summary>puppeteer: 19.3.0</summary>

##
[19.3.0](puppeteer-v19.2.2...puppeteer-v19.3.0)
(2022-11-23)


### Miscellaneous Chores

* **puppeteer:** Synchronize puppeteer versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * puppeteer-core bumped from 19.2.2 to 19.3.0
</details>

<details><summary>puppeteer-core: 19.3.0</summary>

##
[19.3.0](puppeteer-core-v19.2.2...puppeteer-core-v19.3.0)
(2022-11-23)


### Features

* **puppeteer-core:** Infer element type from complex selector
([#9253](#9253))
([bef1061](bef1061))
* **puppeteer-core:** update Chrome launcher flags
([#9239](#9239))
([ae87bfc](ae87bfc))


### Bug Fixes

* remove boundary conditions for visibility
([#9249](#9249))
([e003513](e003513))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: waitForSelector doesn't consider elements above current viewport as "visible"
2 participants