fix: remove boundary conditions for visibility

puppeteer · Nov 14, 2022 · e6f7b8e · e6f7b8e
1 parent 86abe68
commit e6f7b8e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/puppeteer-core/src/injected/util.ts b/packages/puppeteer-core/src/injected/util.ts
@@ -58,11 +58,11 @@ export const checkVisibility = (
   const isVisible =
     style &&
     !HIDDEN_VISIBILITY_VALUES.includes(style.visibility) &&
-    isBoundingBoxVisible(element);
+    !isBoundingBoxEmpty(element);
   return visible === isVisible ? node : false;
 };
 
-function isBoundingBoxVisible(element: Element): boolean {
+function isBoundingBoxEmpty(element: Element): boolean {
   const rect = element.getBoundingClientRect();
-  return rect.width > 0 && rect.height > 0 && rect.right > 0 && rect.bottom > 0;
+  return rect.width === 0 || rect.height === 0;
 }