Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve navigation flakiness #8768

Merged
merged 1 commit into from Aug 10, 2022
Merged

fix: resolve navigation flakiness #8768

merged 1 commit into from Aug 10, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Aug 10, 2022 •
edited

Two main sources of flakiness addressed:

  1. we should dispose the lifecycle watcher after we waited for the navigation response (bad API? we need to refactor but I think it'd be valuable to stabilize tests first without too many changes).
  2. we should wait for the navigation request's response if there is a navigation request in the watcher.

Closes #8644

@OrKoN OrKoN marked this pull request as draft August 10, 2022 09:34
@OrKoN OrKoN force-pushed the fix-nav-flakiness branch 5 times, most recently from a009046 to 3559483 Compare August 10, 2022 13:58
@OrKoN OrKoN requested a review from jrandolf August 10, 2022 15:48
@OrKoN OrKoN marked this pull request as ready for review August 10, 2022 15:48
@OrKoN OrKoN enabled auto-merge (squash) August 10, 2022 15:58
@OrKoN OrKoN merged commit 2580347 into main Aug 10, 2022
@OrKoN OrKoN deleted the fix-nav-flakiness branch August 10, 2022 15:59
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
@YusukeIwaki YusukeIwaki mentioned this pull request Sep 18, 2022
Merged
@OrKoN OrKoN mentioned this pull request Oct 28, 2022
Merged
jrandolf pushed a commit that referenced this pull request Oct 28, 2022
@OrKoN
fix: resolve navigation requests when request fails (#9178)
c11297b 
#8768 fixes flakiness in handling navigations but it didn't account for
the fact that subsequent navigation requests could be aborted via the
request interception. In that case, the navigationResponseReceived
promise would never be resolved. This PR adds a listener for the failed
network requests and resolves the promise if the network request has
failed. Adding test coverage for this seems tricky, as the reproduction
depends on timing of the second navigation request.

Closes #9175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrandolf jrandolf jrandolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: request proxy should proxy requests when configured
2 participants
@OrKoN @jrandolf