fix: use loaderId to reduce test flakiness #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
approved these changes
Aug 1, 2022
This was referenced Aug 1, 2022
jrandolf
pushed a commit
that referenced
this pull request
Aug 2, 2022
leonardo-fernandes
added a commit
to leonardo-fernandes/puppeteer-sharp
that referenced
this pull request
Jun 14, 2023
kblok
pushed a commit
to hardkoded/puppeteer-sharp
that referenced
this pull request
Jun 15, 2023
* Fix PageGotoTests' flakyness. See puppeteer/puppeteer#8717 * Fix PageGotoTests.ShouldWorkWhenNavigatingTo404 when executed in headful mode. See puppeteer/puppeteer#9577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the use of loaderId to determine which type of navigation to wait for when a page navigates using Page.goto. beforeunload handlers in a new document navigation may trigger a few same document navigations and, thus, loaderId is required to distinguish between same-document and new-document navigations.