Fix PageGotoTests' flakyness.

See puppeteer/puppeteer#8717
leonardo-fernandes · Jun 14, 2023 · 6355f99 · 6355f99
1 parent a5ae465
commit 6355f99
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/lib/PuppeteerSharp/LifecycleWatcher.cs b/lib/PuppeteerSharp/LifecycleWatcher.cs
@@ -35,7 +35,6 @@ internal sealed class LifecycleWatcher : IDisposable
         private IRequest _navigationRequest;
         private bool _hasSameDocumentNavigation;
         private bool _swapped;
-        private bool _newDocumentNavigation;
 
         public LifecycleWatcher(
             FrameManager frameManager,
@@ -99,7 +98,6 @@ private void Navigated(object sender, FrameEventArgs e)
                 return;
             }
 
-            _newDocumentNavigation = true;
             CheckLifecycleComplete();
         }
 
@@ -143,7 +141,7 @@ private void CheckLifecycleComplete()
                 _sameDocumentNavigationTaskWrapper.TrySetResult(true);
             }
 
-            if (_swapped || _newDocumentNavigation)
+            if (_swapped || _frame.LoaderId != _initialLoaderId)
             {
                 _newDocumentNavigationTaskWrapper.TrySetResult(true);
             }