chore: disable type tests #8550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
remove_type_tests
branch
from
36f3ead
to
efa56c2
Compare
jrandolf
force-pushed
the
remove_type_tests
branch
from
efa56c2
to
48b64af
Compare
|
I'd prefer to keep the tests to guard against regressions if the types are changed by us by accident. If it interfers with the refactoring, let's disable the tests and re-enable once the refactoring is done? |
jrandolf
force-pushed
the
remove_type_tests
branch
2 times, most recently
from
b7bb1c5
to
5e27ac9
Compare
Done. |
jrandolf
force-pushed
the
remove_type_tests
branch
from
5e27ac9
to
f424c49
Compare
OrKoN
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling type tests for refactoring.