Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TS typing tests #8581

Closed
OrKoN opened this issue Jun 26, 2022 · 2 comments
Closed

Re-enable TS typing tests #8581

OrKoN opened this issue Jun 26, 2022 · 2 comments
Assignees
@jrandolf
Labels
feature

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 26, 2022

Let's re-enable the TS tests and make sure they capture major expectations on how to work with Puppeteer's types: e.g., what is inferred, what is not and in what situations.

Disabled in #8550
@jrandolf
Copy link
Contributor

After investigating this a bit, there is a framework recommended even by Microsoft (see README) that we can use for type testing that actually makes sense. See https://github.com/SamVerschueren/tsd.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 27, 2022

This looks great! Should we introduce this before you proceed with the next typing refactoring?

@OrKoN OrKoN added the feature label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrandolf jrandolf

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OrKoN @jrandolf