chore(agnostification): split up root Puppeteer class #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I drew this diagram as it might help visualise the entry points for each environment. |
jackfranklin
force-pushed
the
split-up-pptr-class
branch
4 times, most recently
from
dae61eb
to
3b515e4
Compare
The `Puppeteer` class had two concerns: * connect to an existing browser * launch a new browser The first of those concerns is needed in all environments, but the second is only needed in Node. #6484 landing enabled us to pull the `Puppeteer` class apart into two: 1. `Puppeteer` which hosts the behaviour for connecting to existing browsers. 2. `PuppeteerNode`, which extends `Puppeteer` and also adds the ability to launch a new browser. This is a non-breaking change, because Node users will still get an instance of a class with all the methods they expect, but it'll be a `PuppeteerNode` rather than `Puppeteer`. I don't expect this to cause people any issues. We also now have new files that are effectively the entry points for Puppeteer: * `node.ts`: the main entry point for Puppeteer on Node. * `web.ts`: the main entry point for Puppeteer on the web. * `node-puppeteer-core.ts`: for those using puppeteer-core (which only exists in Node, not on the web).
jackfranklin
force-pushed
the
split-up-pptr-class
branch
from
3b515e4
to
c6ad697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Puppeteerclass had two concerns:The first of those concerns is needed in all environments, but the
second is only needed in Node.
#6484 landing enabled us to
pull the
Puppeteerclass apart into two:Puppeteerwhich hosts the behaviour for connecting to existingbrowsers.
PuppeteerNode, which extendsPuppeteerand also adds the abilityto launch a new browser.
This is a non-breaking change, because Node users will still get an
instance of a class with all the methods they expect, but it'll be a
PuppeteerNoderather thanPuppeteer. I don't expect this to causepeople any issues.
We also now have new files that are effectively the entry points for
Puppeteer:
node.ts: the main entry point for Puppeteer on Node.web.ts: the main entry point for Puppeteer on the web.node-puppeteer-core.ts: for those using puppeteer-core (which onlyexists in Node, not on the web).