fix(connection): separate send/receive debug logging #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits the logging for send and receive messages in to separate debug channels. This way it is easier to filter and takes advantage of debug's automated coloring to make it easier to visually parse on the command line
jsoverson
force-pushed
the
puppeteer-protocol-debugging
branch
from
d6e947a
to
560f006
Compare
mathiasbynens
approved these changes
Jun 15, 2020
|
@jackfranklin Even in light of the plans to make |
jackfranklin
approved these changes
Jun 15, 2020
|
Thanks @jackfranklin & @mathiasbynens! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the logging for send and receive messages in to separate debug channels.
This way it is easier to filter and takes advantage of
debug's automatic coloring to makeit easier to visually parse on the command line.
Before PR:
After PR:
