Skip to content

Commit

Permalink
fix(connection): separate send/receive debug logging (#6017)
Browse files Browse the repository at this point in the history
This PR splits the logging for send and receive messages in to separate debug channels.
This way it is easier to filter and takes advantage of debug's automated coloring to make
it easier to visually parse on the command line
  • Loading branch information
jsoverson committed Jun 15, 2020
1 parent c701ea1 commit 6e060ce
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/Connection.ts
Expand Up @@ -16,7 +16,8 @@
import { assert } from './helper';
import { Events } from './Events';
import * as debug from 'debug';
const debugProtocol = debug('puppeteer:protocol');
const debugProtocolSend = debug('puppeteer:protocol:SEND ►');
const debugProtocolReceive = debug('puppeteer:protocol:RECV ◀');

import Protocol from './protocol';
import { ConnectionTransport } from './ConnectionTransport';
Expand Down Expand Up @@ -78,14 +79,14 @@ export class Connection extends EventEmitter {
_rawSend(message: {}): number {
const id = ++this._lastId;
message = JSON.stringify(Object.assign({}, message, { id }));
debugProtocol('SEND ► ' + message);
debugProtocolSend(message);
this._transport.send(message);
return id;
}

async _onMessage(message: string): Promise<void> {
if (this._delay) await new Promise((f) => setTimeout(f, this._delay));
debugProtocol('◀ RECV ' + message);
debugProtocolReceive(message);
const object = JSON.parse(message);
if (object.method === 'Target.attachedToTarget') {
const sessionId = object.params.sessionId;
Expand Down

0 comments on commit 6e060ce

Please sign in to comment.