chore: migrate away from Node's EventEmitter #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
commented
Jun 8, 2020
mathiasbynens
approved these changes
Jun 8, 2020
jackfranklin
commented
Jun 8, 2020
| // Two now because we added the handler back. | ||
| expect(handler.callCount).toBe(2); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
a user reported a bug in 3.2 where this code didn't work. I don't think it was a bug in Mitt, but I wanted to add a test that explicitly listened to an event, stopped, and then started again just to make sure. It's a useful test to have IMO.
jackfranklin
force-pushed
the
mitt-again
branch
3 times, most recently
from
8cfafee
to
410412b
Compare
And link to our event emitter instead. This ensures that we don't send anyone erroneously to the NodeJS docs.
jackfranklin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces Mitt (that was released in v3.2 and reverted in v3.3).
The majority of EventEmitter methods are re-implemented in Puppeteer and we will release this as a major version accompanied by release notes that document exactly which methods have been removed to help users migrate.