Merge branch 'puppeteer:main' into feat.cdp_connect_with_headers

puppeteer · Nov 24, 2022 · faabad0 · faabad0
2 parents e240976 + da92055
commit faabad0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -27,12 +27,14 @@ jobs:
         run: |
           npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN
           npm publish --workspace packages/${GITHUB_REF_NAME%-v*}
-      - name: Deprecate old versions
+      - name: Deprecate old Puppeteer versions
         if: ${{ startsWith(github.ref_name, 'puppeteer-v') }}
+        env:
+          NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN_PUPPETEER}}
         run: |
+          npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN
           version_range=$(node tools/get_deprecated_version_range.js)
           npm deprecate puppeteer@"$version_range" "$version_range is no longer supported"
-          npm deprecate puppeteer-core@"$version_range" "$version_range is no longer supported"
   docker-publish:
     name: Publish Docker image
     runs-on: ubuntu-latest

diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -2120,7 +2120,7 @@
   {
     "testIdPattern": "[waittask.spec] waittask specs Frame.waitForSelector should survive cross-process navigation",
     "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["firefox", "headful"],
+    "parameters": ["firefox"],
     "expectations": ["PASS", "FAIL"]
   }
 ]