Skip to content

Commit

Permalink
chore: run Firefox unit tests only
Browse files Browse the repository at this point in the history
  • Loading branch information
whimboo committed Apr 21, 2022
1 parent b6504d7 commit d1dfd45
Showing 1 changed file with 49 additions and 51 deletions.
100 changes: 49 additions & 51 deletions .github/workflows/main.yml
Expand Up @@ -43,36 +43,34 @@ jobs:
run: |
npm run build
- name: Run code checks
run: |
npm run ensure-pinned-deps
npm run lint
# Skipping as it's flakey and we are not currently using the new documentation site in the wild yet.
# See https://github.com/puppeteer/puppeteer/issues/7710 for more info
# npm run generate-docs
npm run ensure-correct-devtools-protocol-revision
npm run test-types-file
- name: Run commit lint
run: |
npm run commitlint
if: github.event_name != 'pull_request'

- name: Run unit tests
uses: nick-invision/retry@v2
env:
CHROMIUM: true
with:
max_attempts: 3
command: xvfb-run --auto-servernum npm run unit
timeout_minutes: 10

- name: Run unit tests with coverage
env:
CHROMIUM: true
run: |
xvfb-run --auto-servernum npm run unit-with-coverage
xvfb-run --auto-servernum npm run assert-unit-coverage
# - name: Run code checks
# run: |
# npm run ensure-pinned-deps
# npm run lint
# npm run generate-docs
# npm run ensure-correct-devtools-protocol-revision
# npm run test-types-file

# - name: Run commit lint
# run: |
# npm run commitlint
# if: github.event_name != 'pull_request'

# - name: Run unit tests
# uses: nick-invision/retry@v2
# env:
# CHROMIUM: true
# with:
# max_attempts: 3
# command: xvfb-run --auto-servernum npm run unit
# timeout_minutes: 10

# - name: Run unit tests with coverage
# env:
# CHROMIUM: true
# run: |
# xvfb-run --auto-servernum npm run unit-with-coverage
# xvfb-run --auto-servernum npm run assert-unit-coverage

- name: Run unit tests on Firefox
uses: nick-invision/retry@v2
Expand All @@ -84,18 +82,18 @@ jobs:
timeout_minutes: 10
command: xvfb-run --auto-servernum npm run funit

- name: Run browser tests
run: |
npm run test-browser
# - name: Run browser tests
# run: |
# npm run test-browser

- name: Test bundling and installation
env:
CHROMIUM: true
run: |
# Note: this modifies package.json to test puppeteer-core.
npm run test-install
# Undo those changes.
git checkout --force
# - name: Test bundling and installation
# env:
# CHROMIUM: true
# run: |
# # Note: this modifies package.json to test puppeteer-core.
# npm run test-install
# # Undo those changes.
# git checkout --force

macos:
# https://github.com/actions/virtual-environments#available-environments
Expand Down Expand Up @@ -125,11 +123,11 @@ jobs:
run: |
npm run build
- name: Run unit tests
env:
CHROMIUM: true
run: |
npm run unit
# - name: Run unit tests
# env:
# CHROMIUM: true
# run: |
# npm run unit

- name: Run unit tests on Firefox
uses: nick-invision/retry@v2
Expand Down Expand Up @@ -168,11 +166,11 @@ jobs:
run: |
npm run build
- name: Run unit tests
env:
CHROMIUM: true
run: |
npm run unit
# - name: Run unit tests
# env:
# CHROMIUM: true
# run: |
# npm run unit

- name: Run unit tests on Firefox
uses: nick-invision/retry@v2
Expand Down

0 comments on commit d1dfd45

Please sign in to comment.