chore: fix tests

puppeteer · Sep 1, 2022 · 9aede4e · 9aede4e
1 parent 49d5593
commit 9aede4e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/common/Frame.ts b/src/common/Frame.ts
@@ -872,8 +872,13 @@ export class Frame {
             element = document.createElement('style');
             element.appendChild(document.createTextNode(content!));
           }
+          let resolve: undefined | ((value?: unknown) => void);
           const promise = new Promise((res, rej) => {
-            element.addEventListener('load', res, {once: true});
+            if (!url) {
+              element.addEventListener('load', res, {once: true});
+            } else {
+              resolve = res;
+            }
             element.addEventListener(
               'error',
               event => {
@@ -887,6 +892,9 @@ export class Frame {
             );
           });
           document.head.appendChild(element);
+          if (resolve) {
+            resolve();
+          }
           await promise;
           return element;
         },

diff --git a/test/src/page.spec.ts b/test/src/page.spec.ts
@@ -1797,7 +1797,7 @@ describe('Page', function () {
         error = error_ as Error;
       }
       expect(error.message).toBe(
-        'Provide an object with a `url`, `path` or `content` property'
+        'Exactly one of `url`, `path`, or `content` may be specified.'
       );
     });