Skip to content

Commit

Permalink
chore: Update CI file to use new set method (#9389)
Browse files Browse the repository at this point in the history
Closes #9373,
Fixes #9296
  • Loading branch information
Lightning00Blade committed Dec 9, 2022
1 parent afc7588 commit 89ff872
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
needs_deploying: ${{ steps.needs_deploying.outputs.value }}
steps:
- name: Check out repository
uses: actions/checkout@v3.0.2
uses: actions/checkout@v3.1.0
with:
fetch-depth: 2
- name: Set up Node.js
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
else
needs_deploying=false
fi
echo "::set-output name=value::$needs_deploying"
echo "value=$needs_deploying" >> $GITHUB_OUTPUT
deploy-docs:
needs: check-docs
Expand Down
2 changes: 1 addition & 1 deletion docs/api/puppeteer.page.evaluate.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ sidebar_label: Page.evaluate

Evaluates a function in the page's context and returns the result.

If the function passed to `page.evaluteHandle` returns a Promise, the function will wait for the promise to resolve and return its value.
If the function passed to `page.evaluateHandle` returns a Promise, the function will wait for the promise to resolve and return its value.

#### Signature:

Expand Down
2 changes: 1 addition & 1 deletion docs/api/puppeteer.page.evaluatehandle.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Promise<[HandleFor](./puppeteer.handlefor.md)<Awaited<ReturnType<Fun

The only difference between [page.evaluate](./puppeteer.page.evaluate.md) and `page.evaluateHandle` is that `evaluateHandle` will return the value wrapped in an in-page object.

If the function passed to `page.evaluteHandle` returns a Promise, the function will wait for the promise to resolve and return its value.
If the function passed to `page.evaluateHandle` returns a Promise, the function will wait for the promise to resolve and return its value.

You can pass a string instead of a function (although functions are recommended as they are easier to debug and use with TypeScript):

Expand Down
2 changes: 1 addition & 1 deletion docs/api/puppeteer.page.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ page.off('request', logRequest);
| [emulateNetworkConditions(networkConditions)](./puppeteer.page.emulatenetworkconditions.md) | | <p>This does not affect WebSockets and WebRTC PeerConnections (see https://crbug.com/563644). To set the page offline, you can use [Page.setOfflineMode()](./puppeteer.page.setofflinemode.md).</p><p>A list of predefined network conditions can be used by importing [PredefinedNetworkConditions](./puppeteer.predefinednetworkconditions.md).</p> |
| [emulateTimezone(timezoneId)](./puppeteer.page.emulatetimezone.md) | | |
| [emulateVisionDeficiency(type)](./puppeteer.page.emulatevisiondeficiency.md) | | Simulates the given vision deficiency on the page. |
| [evaluate(pageFunction, args)](./puppeteer.page.evaluate.md) | | <p>Evaluates a function in the page's context and returns the result.</p><p>If the function passed to <code>page.evaluteHandle</code> returns a Promise, the function will wait for the promise to resolve and return its value.</p> |
| [evaluate(pageFunction, args)](./puppeteer.page.evaluate.md) | | <p>Evaluates a function in the page's context and returns the result.</p><p>If the function passed to <code>page.evaluateHandle</code> returns a Promise, the function will wait for the promise to resolve and return its value.</p> |
| [evaluateHandle(pageFunction, args)](./puppeteer.page.evaluatehandle.md) | | |
| [evaluateOnNewDocument(pageFunction, args)](./puppeteer.page.evaluateonnewdocument.md) | | <p>Adds a function which would be invoked in one of the following scenarios:</p><p>- whenever the page is navigated</p><p>- whenever the child frame is attached or navigated. In this case, the function is invoked in the context of the newly attached frame.</p><p>The function is invoked after the document was created but before any of its scripts were run. This is useful to amend the JavaScript environment, e.g. to seed <code>Math.random</code>.</p> |
| [exposeFunction(name, pptrFunction)](./puppeteer.page.exposefunction.md) | | <p>The method adds a function called <code>name</code> on the page's <code>window</code> object. When called, the function executes <code>puppeteerFunction</code> in node.js and returns a <code>Promise</code> which resolves to the return value of <code>puppeteerFunction</code>.</p><p>If the puppeteerFunction returns a <code>Promise</code>, it will be awaited.</p><p>:::note</p><p>Functions installed via <code>page.exposeFunction</code> survive navigations.</p><p>:::note</p> |
Expand Down
4 changes: 2 additions & 2 deletions packages/puppeteer-core/src/api/Page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ export class Page extends EventEmitter {
* `page.evaluateHandle` is that `evaluateHandle` will return the value
* wrapped in an in-page object.
*
* If the function passed to `page.evaluteHandle` returns a Promise, the
* If the function passed to `page.evaluateHandle` returns a Promise, the
* function will wait for the promise to resolve and return its value.
*
* You can pass a string instead of a function (although functions are
Expand Down Expand Up @@ -1965,7 +1965,7 @@ export class Page extends EventEmitter {
/**
* Evaluates a function in the page's context and returns the result.
*
* If the function passed to `page.evaluteHandle` returns a Promise, the
* If the function passed to `page.evaluateHandle` returns a Promise, the
* function will wait for the promise to resolve and return its value.
*
* @example
Expand Down

0 comments on commit 89ff872

Please sign in to comment.