Skip to content

Commit

Permalink
docs: fix typo in Viewport fields (#9293)
Browse files Browse the repository at this point in the history
The `deviceScalarFactor` field of `Viewport` is actually named
`deviceScaleFactor`.
  • Loading branch information
GuillaumeGomez authored and OrKoN committed Nov 23, 2022
1 parent 16784fc commit 6784f1c
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions docs/contributing.md
Expand Up @@ -322,3 +322,21 @@ In the event release-please fails, the following needs to be done:

2. Create a GitHub release for each package, following the practice of previous
releases.

## Bug and PR triage

[Check incoming bug reports](https://github.com/puppeteer/puppeteer/issues) that do not have a `confirmed` or `needs-feedback` label:

1. Make sure the issue labeled as either `bug` or `feature`.
2. If the issue does not have a clear repro or you cannot repro, ask for the repro and set the `needs-feedback` label.
3. Follow-up on the issues you previously asked for a feedback on (you should get a notification on GitHub when the user responds).
4. If the user does not provide feedback, the issue will be closed by the stale bot eventually.
5. If you are able to reproduce the issue, add the label "confirmed".
6. If the bug is on the Chromium side, create a corresponding crbug.com issue and label the Github issue with the "upstream" label and post a link to crbug.com in the comments.
7. If the issue is not related to either Puppeteer or Chromium, close the issue.
8. If the issue is about missing/incorrect documentation, label it as `documentation`.

Issues with PDFs:

1. If the issue reproduces using the regular print dialog and/or headful, file a crbug.com against the Blink Layout component.
2. If the issue is specific to the headless headless, file an issue on crbug.com against the headless component.

0 comments on commit 6784f1c

Please sign in to comment.