chore: don't run destroyHandles if realm is already disposed (#12365)

puppeteer · Apr 30, 2024 · 3103744 · 3103744
1 parent 41d4320
commit 3103744
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/puppeteer-core/src/api/Realm.ts b/packages/puppeteer-core/src/api/Realm.ts
@@ -95,10 +95,14 @@ export abstract class Realm implements Disposable {
 
   #disposed = false;
   /** @internal */
-  [disposeSymbol](): void {
+  dispose(): void {
     this.#disposed = true;
     this.taskManager.terminateAll(
       new Error('waitForFunction failed: frame got detached.')
     );
   }
+  /** @internal */
+  [disposeSymbol](): void {
+    this.dispose();
+  }
 }
diff --git a/packages/puppeteer-core/src/bidi/Realm.ts b/packages/puppeteer-core/src/bidi/Realm.ts
@@ -53,6 +53,7 @@ export abstract class BidiRealm extends Realm {
   protected initialize(): void {
     this.realm.on('destroyed', ({reason}) => {
       this.taskManager.terminateAll(new Error(reason));
+      this.dispose();
     });
     this.realm.on('updated', () => {
       this.internalPuppeteerUtil = undefined;
@@ -224,6 +225,10 @@ export abstract class BidiRealm extends Realm {
   }
 
   async destroyHandles(handles: Array<BidiJSHandle<unknown>>): Promise<void> {
+    if (this.disposed) {
+      return;
+    }
+
     const handleIds = handles
       .map(({id}) => {
         return id;