Skip to content

Commit

Permalink
fix: update missing product message (#9207)
Browse files Browse the repository at this point in the history
This PR updates the error message printed when a browser cannot be
found.

Related: #9192,
#9162
  • Loading branch information
jrandolf committed Nov 3, 2022
1 parent 09253ba commit 29f47e2
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions packages/puppeteer-core/src/node/ProductLauncher.ts
Expand Up @@ -117,11 +117,17 @@ export class ProductLauncher {
switch (this.product) {
case 'chrome':
throw new Error(
`Run \`npm install\` to download the correct Chromium revision (${this.puppeteer.browserRevision}).`
`Could not find Chromium (rev. ${this.puppeteer.browserRevision}). This can occur if either\n` +
' 1. you did not perform an installation before running the script (e.g. `npm install`) or\n' +
` 2. your cache path is incorrectly configured (which is: ${this.puppeteer.configuration.cacheDirectory}).\n` +
'For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration.'
);
case 'firefox':
throw new Error(
`Run \`PUPPETEER_PRODUCT=firefox npm install\` to download a supported Firefox browser binary.`
`Could not find Firefox (rev. ${this.puppeteer.browserRevision}). This can occur if either\n` +
' 1. you did not perform an installation for Firefox before running the script (e.g. `PUPPETEER_PRODUCT=firefox npm install`) or\n' +
` 2. your cache path is incorrectly configured (which is: ${this.puppeteer.configuration.cacheDirectory}).\n` +
'For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration.'
);
}
}
Expand Down

0 comments on commit 29f47e2

Please sign in to comment.