chore: use map instead of plain object (#5068)

puppeteer · Oct 23, 2019 · 06dbb72 · 06dbb72
1 parent 81d2600
commit 06dbb72
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/lib/LifecycleWatcher.js b/lib/LifecycleWatcher.js
@@ -31,7 +31,7 @@ class LifecycleWatcher {
     else if (typeof waitUntil === 'string')
       waitUntil = [waitUntil];
     this._expectedLifecycle = waitUntil.map(value => {
-      const protocolEvent = puppeteerToProtocolLifecycle[value];
+      const protocolEvent = puppeteerToProtocolLifecycle.get(value);
       assert(protocolEvent, 'Unknown value for options.waitUntil: ' + value);
       return protocolEvent;
     });
@@ -188,11 +188,11 @@ class LifecycleWatcher {
   }
 }
 
-const puppeteerToProtocolLifecycle = {
-  'load': 'load',
-  'domcontentloaded': 'DOMContentLoaded',
-  'networkidle0': 'networkIdle',
-  'networkidle2': 'networkAlmostIdle',
-};
+const puppeteerToProtocolLifecycle = new Map([
+  ['load', 'load'],
+  ['domcontentloaded', 'DOMContentLoaded'],
+  ['networkidle0', 'networkIdle'],
+  ['networkidle2', 'networkAlmostIdle'],
+]);
 
 module.exports = {LifecycleWatcher};