fix: check if async error has a stack (#4017)

puppeteer · Mar 5, 2019 · 02b2451 · 02b2451
1 parent 9db09fe
commit 02b2451
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/experimental/puppeteer-firefox/lib/helper.js b/experimental/puppeteer-firefox/lib/helper.js
@@ -32,7 +32,7 @@ class Helper {
         return method.call(this, ...args).catch(e => {
           const stack = syncStack.stack.substring(syncStack.stack.indexOf('\n') + 1);
           const clientStack = stack.substring(stack.indexOf('\n'));
-          if (!e.stack.includes(clientStack))
+          if (e instanceof Error && e.stack && !e.stack.includes(clientStack))
             e.stack += '\n  -- ASYNC --\n' + stack;
           throw e;
         });

diff --git a/lib/helper.js b/lib/helper.js
@@ -109,7 +109,7 @@ class Helper {
         return method.call(this, ...args).catch(e => {
           const stack = syncStack.stack.substring(syncStack.stack.indexOf('\n') + 1);
           const clientStack = stack.substring(stack.indexOf('\n'));
-          if (!e.stack.includes(clientStack))
+          if (e instanceof Error && e.stack && !e.stack.includes(clientStack))
             e.stack += '\n  -- ASYNC --\n' + stack;
           throw e;
         });