Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifing wrk using environment variable. #3358

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Allow specifing wrk using environment variable. #3358

merged 1 commit into from
Apr 2, 2024

Conversation

ioquatix
Copy link
Contributor

@ioquatix ioquatix commented Apr 2, 2024 •
edited

Using a different build of wrk is tricky without this.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg dentarg merged commit 2bfa233 into puma:master Apr 2, 2024
72 of 74 checks passed
@ioquatix ioquatix deleted the benchmark-explicit-wrk branch April 2, 2024 05:37
@ioquatix
Copy link
Contributor Author

ioquatix commented Apr 2, 2024

Oh, thanks for merging this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
CI / Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ioquatix @dentarg