Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternative schemes in Binder #3348

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomurb
Copy link

@tomurb tomurb commented Mar 18, 2024

Description

Allows for adding before_parse hooks to the Binder#parse method.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • * All new and existing tests passed, including Rubocop.

Closes #3302

@tomurb tomurb force-pushed the 3343-restrict-cipher-cuits-tls-1-3 branch from 9e61153 to e9353b6 Compare March 20, 2024 15:49
@tomurb tomurb marked this pull request as ready for review March 20, 2024 18:21
@dentarg dentarg changed the title Allow alternative schemes in Binder (#3302 ) Allow alternative schemes in Binder Apr 2, 2024
@dentarg
Copy link
Member

dentarg commented Apr 2, 2024

It would be good to document / show how one can use this (it is not entirely clear to me, even when I've read the linked issue, but I have also never developed a plugin for Puma)

Can something be added to https://github.com/puma/puma/blob/master/docs/plugins.md?

@dentarg dentarg added waiting-for-changes Waiting on changes from the requestor feature plugins labels Apr 2, 2024
@tomurb
Copy link
Author

tomurb commented Apr 3, 2024

I've added some documentation. I also didn't develop any plugins. I don't know how to write an example. I could maybe add that link for context and add how that change would make difference for acme-puma codebase? (change of the method name, and removal of lib/puma/acme/binder.rb file)

Does that sound right?

@tomurb tomurb force-pushed the 3343-restrict-cipher-cuits-tls-1-3 branch from 7c862e5 to e829dd1 Compare April 3, 2024 14:24
@dentarg
Copy link
Member

dentarg commented Apr 3, 2024

could maybe add that link for context and add how that change would make difference for acme-puma codebase?

I think that would be good

@tomurb tomurb force-pushed the 3343-restrict-cipher-cuits-tls-1-3 branch from e829dd1 to 49785dc Compare April 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature plugins waiting-for-changes Waiting on changes from the requestor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow alternative schemes in Binder
2 participants