Refactor Puma::Cluster::WorkerHandle#ping!
#3347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
refactor-ping!
branch
4 times, most recently
from
5e920e5
to
6ec6b68
Compare
joshuay03
commented
Mar 19, 2024
| hash[key.to_sym] = captures[key].to_i | ||
| hash | ||
| end | ||
| @last_status = status.match(STATUS_PATTERN).named_captures.map { |c_name, c| [c_name.to_sym, c.to_i] }.to_h |
There was a problem hiding this comment.
Unfortunately this neater solution doesn't work with < 2.5 Ruby:
Suggested change
| @last_status = status.match(STATUS_PATTERN).named_captures.map { |c_name, c| [c_name.to_sym, c.to_i] }.to_h | |
| @last_status = status.match(STATUS_PATTERN).named_captures.to_h { |c_name, c| [c_name.to_sym, c.to_i] } |
joshuay03
force-pushed
the
refactor-ping!
branch
from
2c19a78
to
6a915f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assuming minor cosmetic changes are accepted, here's a small refactor of
Puma::Cluster::WorkerHandle#ping!which makes it more succint by removing an unncessary assignment and reducing imperative operations.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.