Response headers set to lowercase #3305
Open
+93
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
reviewed
Jan 8, 2024
nikhilbhatt
force-pushed
the
return_lowercase_response_headers
branch
from
fcefcee
to
517b2e0
Compare
|
@nikhilbhatt There is still one failed test here could you please fix it. |
nikhilbhatt
force-pushed
the
return_lowercase_response_headers
branch
from
517b2e0
to
402fe68
Compare
nikhilbhatt
force-pushed
the
return_lowercase_response_headers
branch
from
402fe68
to
ee713ec
Compare
fixed |
|
@nikhilbhatt what about this one and 408 error response Line 128 in 5145708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3250
Response headers returned by puma will always be lowercase.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.