[ci skip] Note symlink mechanism in restart documentation for hot restart #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
approved these changes
Dec 26, 2023
nateberkopec
pushed a commit
that referenced
this pull request
Jan 2, 2024
nateberkopec
pushed a commit
that referenced
this pull request
Jan 2, 2024
nateberkopec
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi! I recently tried to set up puma with hot restart, deployed with capistrano to a symlinked directory, and ran into the problem that after deploy changes to the app were not picked up. I have only glanced over the phased restart section before and didn't realize that the "cd to
directoryon startup" mechanism is also relevant for hot restarts. Here's a minor doc change to clarify that.Your checklist for this pull request
I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.[ci skip]to the title of the PR.If this closes any issues, I have added "Closes#issue" to the PR description or my commit messages.All new and existing tests passed, including Rubocop.