Add attr_reader options for Puma::Server #3272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
attr_reader :options
for Puma::Server.On the one hand, it can reduce the use of instance variables.
Using the reader method can more clearly indicate that this is a read-only attribution and will not be changed in other methods.
On the other hand, It allows
Puma::Server
to expose@options
for external use.I have a scenario that requires this feature: Fetch PUMA Workers count of options in Rails runtime.
When using PUMA Cli to start the service, we can indeed do this
::Puma.cli_config.options[:workers]
,but if we start the server through
rails server
,Puma
can not responsecli_config
method.Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.