Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ragel.yml - use 'bundle exec rake' instead of 'rake' #3269

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Oct 28, 2023

Description

Rake 13.1.0 has been released, and the ragel CI is failing in my fork.

BUNDLE_PATH is set by setup/ruby using bundle config --local path <path>, so the gems installed by it are not accessible unless bundle exec is used. Hence, one should always use bundle exec or require 'bundler/setup'.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 16d5dc9 into puma:master Oct 28, 2023
60 of 64 checks passed
@MSP-Greg MSP-Greg deleted the 00-ragel branch October 28, 2023 15:01
nateberkopec pushed a commit that referenced this pull request Jan 2, 2024
nateberkopec pushed a commit that referenced this pull request Jan 2, 2024
nateberkopec pushed a commit that referenced this pull request Jan 2, 2024
nateberkopec pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants