Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] draft: Add new set of aliases #3258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zedbydade
Copy link

@zedbydade zedbydade commented Oct 12, 2023

Description

Hi folks, I built a new set of aliases that we discussed in issue #3213. I use the existing after_worker_boot as a base for the new set. Will that be the way? That MR will also have documentation improvement.

Thank you all

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@@ -1,8 +1,5 @@
# frozen_string_literal: true

module Puma
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, when did that get added?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nateberkopec
Copy link
Member

Thanks for opening this @zedbydade! Welcome to Puma :)

There are actually quite a few more hooks beginning with on_ than I realized... hm. I want to think about this one a bit.

@nateberkopec nateberkopec added the waiting-for-review Waiting on review from anyone label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants