[CI] test_puma_server.rb - use PumaSocket #3251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_http10_req_to_http10_resp test_http11_req_to_http11_resp
dentarg
reviewed
Dec 11, 2023
| @@ -301,7 +301,7 @@ def tempfile_create(basename, data, mode: File::BINARY) | |||
| fio.write data | |||
| fio.flush | |||
| fio.rewind | |||
| @ios << fio | |||
| @ios_to_close << fio | |||
There was a problem hiding this comment.
We can push this change to master directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described. Previously, there were a lot of tests that used a method
header, which has been removed. The method returned the status line and all the header lines as an array. The new method used,Response#headers, only returns the headers.Two tests were added that test the status line return, just in case. Even with the two extra methods, the file has decreased by about 50 lines.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.