Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null_io.rb - add set_encoding, similar to IO#set_encoding #3214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MSP-Greg
Copy link
Member

Description

See rack/rack#2115, which identifies a bug that occurs with Rack::MockRequest.env_for.

See also Rack Spec: The Input Stream.

More IO instance methods may need to be added to Puma::NullIO.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg added the bug label Aug 27, 2023
@MSP-Greg
Copy link
Member Author

@nateberkopec Thanks.

The current PR adds set_encoding, I think adding external_encoding and internal_encoding would also be a good idea. I'll update soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants