Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update URLMap Regexp usage for Ruby v3.3 #3165

Merged
merged 4 commits into from Jun 6, 2023
Merged

update URLMap Regexp usage for Ruby v3.3 #3165

merged 4 commits into from Jun 6, 2023

Commits on May 28, 2023

  1. update URLMap Regexp usage for Ruby v3.3 

    Ruby v3.3.0-preview1 doesn't support passing 3 arguments to
`Regexp.new`, so update `URLMap` to use a 2 argument version instead.
    @fallwith
    fallwith committed May 28, 2023
    Configuration menu
    Copy the full SHA
    617470e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Add unit test for PR 3165 

    With a `Gemfile` that excludes `rack`, have Puma use its own `URLMap`
class to handle the mapping of the route defined in `config.ru`. Without
the fix provided by PR 3165, this new test will time out.
    @fallwith
    fallwith committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8374a5b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. test_url_map.rb - run single

    @MSP-Greg @fallwith
    MSP-Greg authored and fallwith committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    d0a7e7e View commit details
    Browse the repository at this point in the history

  2. test/url_map_test/config.ru - check whether Rack::URLMap is defined 

    Just in case...
    @MSP-Greg
    MSP-Greg committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ffcc83e View commit details
    Browse the repository at this point in the history