[CI] test_integration_ssl_session.rb - wait for session callback #3158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I haven't seen any of these tests fail, but I have seen some retry. All of the tests create two ssl requests, and the SSLSockets have
OpenSSL::SSL::SSLContext#session_new_cb
set.This PR adds code so the second request waits for the callback. The tests haven't failed/retried in the limited CI testing I've done.
Note that, like many of the tests involving 'retry', I've never had these tests fail locally.
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.