New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support custom logger with request logs #3140
base: master
Are you sure you want to change the base?
Feature/support custom logger with request logs #3140
Conversation
can't see you have ;) |
@dentarg sorry, i will have a crack at them tomorrow, my fault for pushing a small pr at the end of the day |
@dentarg hey i was hoping for some guidance i was able to get a test going and working as expected in or is this one working test sufficient? |
feature/support-custom-logger-with-request-logs
@nateberkopec should be all fixed up now 👍 |
Would love to start using this, I just set up a custom logger since I assumed it would be used for the request logs as well. My use-case is filtering noisy requests from the log (health check requests): class CustomLogger
def initialize(output = $stdout)
@output = output
end
def write(msg)
return if msg.include?('GET /health')
@output.puts msg
@output.flush
end
end |
Marking as breaking/v7. We now have 2 changes on master for v7, maybe one or two more and we can consider a major release. Samuel's fiber-per-request might be a good "banner" feature for it as well. |
Which are those? I just created an 7.0.0 milestone, would be good to add their issues/PRs to it. |
Description
This is just a small adjustment to what was done with #2770
This just also uses the custom logger for request logs aswell
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.