Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loggers - internal_write - catch Errno::EINVAL #3091

Merged
merged 1 commit into from Mar 28, 2023

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Mar 2, 2023

Description

The following appeared in a recent CI job:

D:/a/puma/puma/lib/puma/log_writer.rb:75:in `flush': Invalid argument (Errno::EINVAL)
  from D:/a/puma/puma/lib/puma/log_writer.rb:75:in `internal_write'
  from D:/a/puma/puma/lib/puma/log_writer.rb:62:in `log'
  from D:/a/puma/puma/lib/puma/launcher.rb:321:in `log'
  from D:/a/puma/puma/lib/puma/launcher.rb:414:in `rescue in setup_signals'

The error raised can happen in the internal_write method of both LogWriter & ErrorLogger. Error should be caught...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg added the bug label Mar 2, 2023
@vzajkov
Copy link
Contributor

vzajkov commented Mar 28, 2023

Thank you for this @MSP-Greg .

Is this alright to merge in? I believe this bug is preventing #2770 from passing checks.

@MSP-Greg
Copy link
Member Author

@vzajkov

I don't think this is blocking, as the last failed CI job in #2700 was an intermittent failure. A rebase on master on your branch will force a new CI run.

Regardless, I'll merge this.

@MSP-Greg MSP-Greg merged commit 38d657d into puma:master Mar 28, 2023
@MSP-Greg MSP-Greg deleted the 00-log-writer-bug branch March 28, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants