Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] turbo-rails is now passing #3076

Merged
merged 1 commit into from
Feb 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 7 additions & 17 deletions .github/workflows/turbo-rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

turbo-rails:
name: >-
${{ matrix.os }} Ruby ${{ matrix.ruby }} Rails ${{ matrix.rails-version }}
${{ matrix.os }} Ruby ${{ matrix.ruby }} Rails ${{ matrix.rails }}
needs: skip_duplicate_runs
runs-on: ${{ matrix.os }}
if: |
Expand All @@ -25,13 +25,13 @@ jobs:
fail-fast: false
matrix:
include:
- { os: ubuntu-20.04 , ruby: '2.7', rails-version: '6.1' }
- { os: ubuntu-20.04 , ruby: '3.1', rails-version: '7.0' }
- { os: ubuntu-20.04 , ruby: '3.2', rails-version: '7.0' }
- { os: ubuntu-22.04 , ruby: head , rails-version: '7.0' }
- { os: ubuntu-20.04 , ruby: '2.7', rails: '6.1' }
- { os: ubuntu-20.04 , ruby: '3.1', rails: '7.0' }
- { os: ubuntu-20.04 , ruby: '3.2', rails: '7.0' }
- { os: ubuntu-22.04 , ruby: head , rails: '7.0' }
env:
CI: true
RAILS_VERSION: "${{ matrix.rails-version }}"
RAILS_VERSION: "${{ matrix.rails }}"

steps:
- name: checkout hotwired/turbo-rails
Expand All @@ -49,9 +49,6 @@ jobs:
SRC="Silent: true"
DST="Silent: false, Threads: '1:4'"
sed -i "s/$SRC/$DST/" test/application_system_test_case.rb
SRC="visit echo_messages_path"
DST="visit echo_messages_path; sleep 0.001"
sed -i "s/$SRC/$DST/" test/system/broadcasts_test.rb

- name: load ruby
uses: ruby/setup-ruby@v1
Expand All @@ -66,11 +63,4 @@ jobs:

- name: turbo-rails test
id: test
run: bin/test test/**/*_test.rb -v
continue-on-error: true
if: success()

- name: >-
Test outcome: ${{ steps.test.outcome }}
# every step must define a `uses` or `run` key
run: echo NOOP
run: bin/test test/**/*_test.rb -vd