Allow to use preload_app! with fork_worker
#2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far it was incompatible because true phased restart are incompatible with preload_app. But `fork_worker` doesn't do a phased restart per say, it just piggy back on the implementation to ask worker #0 to refork its siblings. So we can just bypass that check and it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #2099
So far it was incompatible because true phased restart are incompatible with
preload_app.But
fork_workerdoesn't do a phased restart per say, it just piggy back on the implementation to ask worker #0 to refork its siblings.So we can just bypass that check and it works.