Patch Rubocop to work with newer Psych versions #2779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Thanks, looks like we can bump RuboCop to 0.64.0 instead of patching it and still have compatibility with Ruby 2.2. I'm not seeing exactly what changed recently in RubyGems to make this happening now, (Psych 4.0 was released a while ago, this summer), but saving a bunch of links I looked at anyways: |
dentarg
added a commit
that referenced
this pull request
Dec 31, 2021
Last version we can use while still having Ruby 2.2 support, 0.65.0 drops it: https://github.com/rubocop/rubocop/blob/0c0bee18073201396f679848954235d10b9f8355/CHANGELOG.md#0650-2019-02-19 Fixes issues with RubyGems and Psych: #2779
|
I couldn't push to your branch so I opened up a new PR with a commit bumping RuboCop instead: #2783 |
dentarg
added a commit
that referenced
this pull request
Dec 31, 2021
* Patch Rubocop's yaml_safe_load to work with newer Psych versions * Fix rubocop namespace * Remove rubocop skip condition from workflow steps * Fix rubygems warnings about required_ruby_version bug * Fix step name * Use RuboCop 0.64.0 Last version we can use while still having Ruby 2.2 support, 0.65.0 drops it: https://github.com/rubocop/rubocop/blob/0c0bee18073201396f679848954235d10b9f8355/CHANGELOG.md#0650-2019-02-19 Fixes issues with RubyGems and Psych: #2779 Co-authored-by: Dalibor Nasevic <dalibor.nasevic@gmail.com>
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* Patch Rubocop's yaml_safe_load to work with newer Psych versions * Fix rubocop namespace * Remove rubocop skip condition from workflow steps * Fix rubygems warnings about required_ruby_version bug * Fix step name * Use RuboCop 0.64.0 Last version we can use while still having Ruby 2.2 support, 0.65.0 drops it: https://github.com/rubocop/rubocop/blob/0c0bee18073201396f679848954235d10b9f8355/CHANGELOG.md#0650-2019-02-19 Fixes issues with RubyGems and Psych: puma#2779 Co-authored-by: Dalibor Nasevic <dalibor.nasevic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most recent RubyGems versions go with Psych >= 4.0 that breaks the RuboCop rake task. We use an old RuboCop version to target Ruby 2.2. So, we cannot upgrade RuboCop to latest and we have to patch it to work with the newer Psych versions.
We're also fixing some CI warnings for Ruby versions 2.3 - 2.5 for RubyGems versions having a bug that prevents
required_ruby_versionfrom working for Bundler.You can see the failing CI builds here: https://github.com/puma/puma/actions/runs/1619499856.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.