Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run rubocop on non-CRuby #2737

Merged
merged 1 commit into from Oct 30, 2021
Merged

Do not run rubocop on non-CRuby #2737

merged 1 commit into from Oct 30, 2021

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Oct 30, 2021

It does not seem useful (redundant with running it on CRuby), makes builds slower, and also sometimes makes builds fail: https://github.com/puma/puma/runs/4047984193?check_suite_focus=true

It does not seem useful (redundant with running it on CRuby), makes builds slower, and also sometimes makes builds fail: https://github.com/puma/puma/runs/4047984193?check_suite_focus=true
Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@dentarg
Copy link
Member

dentarg commented Oct 30, 2021

I'll note that this has been discussed before at #2198 (comment) but I think we prefer green (and faster) tests over keeping it the same.

@dentarg
Copy link
Member

dentarg commented Oct 30, 2021

sometimes makes builds fail: https://github.com/puma/puma/runs/4047984193?check_suite_focus=true

Do you have any idea as to why @eregon?

@dentarg dentarg merged commit c8e93a1 into puma:master Oct 30, 2021
@eregon eregon deleted the patch-1 branch October 30, 2021 22:15
@eregon
Copy link
Contributor Author

eregon commented Oct 30, 2021

I'll note that this has been discussed before at #2198 (comment) but I think we prefer green (and faster) tests over keeping it the same.

Looks like the conclusion was the same: only run it on CRuby: https://github.com/puma/puma/pull/2198/files#diff-ce0dee93a528f6c7648f4cd671a3ec7be6a80f976c88f3aa1c322b7a80828fbaR46

Do you have any idea as to why @eregon?

Not sure, maybe it's a out of memory error. It seems GitHub Actions is really terse when a process gets killed.

@nateberkopec
Copy link
Member

Thanks for all fixes @eregon

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
It does not seem useful (redundant with running it on CRuby), makes builds slower, and also sometimes makes builds fail: https://github.com/puma/puma/runs/4047984193?check_suite_focus=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants